nastra commented on code in PR #16148:
URL: https://github.com/apache/iceberg/pull/16148#discussion_r3168182335


##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -3986,6 +3987,112 @@ protected RESTSessionCatalog newSessionCatalog(
     return catalog;
   }
 
+  @Test
+  public void testAddSchemaWithExistingIdAndDifferentSchema() {

Review Comment:
   there is actually code in `TableMetadata` / `ViewMetadata` that would detect 
that schemas differ and would assign it a different schema ID, so I don't see 
how this would fail in practice when the normal Table / View APIs are being 
used. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to