laserninja commented on code in PR #16112:
URL: https://github.com/apache/iceberg/pull/16112#discussion_r3165351315
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOCredentialRefresh.java:
##########
@@ -265,4 +267,91 @@ public void credentialRefreshWithinFiveMinuteWindow() {
});
}
}
+
+ @Test
+ public void refreshedCredentialsAreImmutable() throws Exception {
Review Comment:
Ahh, yes. I'll drop this test. It only inspects a private field via
reflection and doesn't exercise the real concern. I'll replace it with the Kryo
round-trip test mentioned in your other comment, which actually verifies the
post-refresh serialization path you flagged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
