laserninja opened a new pull request, #16112: URL: https://github.com/apache/iceberg/pull/16112
In S3FileIO and GCSFileIO, storageCredentials was initialized and refreshed with a mutable ArrayList. While the volatile reference replacement is safe under the JMM, publishing a mutable list is unnecessarily fragile. - Change the field initializer to ImmutableList.of() - Change refreshStorageCredentials() to assign ImmutableList.copyOf() instead of Lists.newArrayList(), ensuring the published list cannot be mutated by any reader after publication setCredentials() keeps Lists.newArrayList() to preserve Kryo serde compatibility for the external credential-injection path. Fixes #16034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
