nastra commented on code in PR #16112:
URL: https://github.com/apache/iceberg/pull/16112#discussion_r3154274857
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -469,7 +469,7 @@ private void refreshStorageCredentials() {
.collect(Collectors.toList());
if (!refreshed.isEmpty() && !isResourceClosed.get()) {
- this.storageCredentials = Lists.newArrayList(refreshed);
+ this.storageCredentials = ImmutableList.copyOf(refreshed);
Review Comment:
what happens if Kryo serde comes into play after this? Kryo was the main
reason to use a modifiable collection. We need to have a test that verifies
this still works with Kryo (which I suspect it won't)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
