pvary commented on code in PR #15843:
URL: https://github.com/apache/iceberg/pull/15843#discussion_r3110088487
##########
orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:
##########
@@ -515,11 +515,11 @@ static boolean isOptional(TypeDescription orcType) {
return true;
}
- static TypeDescription removeIds(TypeDescription type) {
+ public static TypeDescription removeIds(TypeDescription type) {
Review Comment:
don't add anything to the public API
##########
orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:
##########
@@ -515,11 +515,11 @@ static boolean isOptional(TypeDescription orcType) {
return true;
}
- static TypeDescription removeIds(TypeDescription type) {
+ public static TypeDescription removeIds(TypeDescription type) {
return OrcSchemaVisitor.visit(type, new RemoveIds());
}
- static boolean hasIds(TypeDescription orcSchema) {
+ public static boolean hasIds(TypeDescription orcSchema) {
Review Comment:
don't add anything to the public API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
