pvary commented on code in PR #15843:
URL: https://github.com/apache/iceberg/pull/15843#discussion_r3110085223
##########
core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java:
##########
@@ -90,7 +90,7 @@ public static org.apache.iceberg.Schema toIceberg(Schema
schema) {
return new org.apache.iceberg.Schema(fields);
}
- static boolean hasIds(Schema schema) {
+ public static boolean hasIds(Schema schema) {
Review Comment:
I don't like these changes. We are adding public methods for testing
purposes only.
Not an elegant, but possible solution is to create an util class in the
`data/srcr/test/java/org/apache/iceberg/avro` directory which is public, but
only in test package.
This way we don't expose these methods, but still could use in our tests.
@nastra: Any better ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
