Guosmilesmile commented on code in PR #15843:
URL: https://github.com/apache/iceberg/pull/15843#discussion_r3123557042
##########
core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java:
##########
@@ -90,7 +90,7 @@ public static org.apache.iceberg.Schema toIceberg(Schema
schema) {
return new org.apache.iceberg.Schema(fields);
}
- static boolean hasIds(Schema schema) {
+ public static boolean hasIds(Schema schema) {
Review Comment:
I saw that many of the methods in these utility classes are static, which
made me think I could just add them directly. I've now revised my approach by
adding these methods to the utility classes under the test package of the
corresponding module, avoiding any changes to the production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
