hemanthboyina commented on code in PR #15979:
URL: https://github.com/apache/iceberg/pull/15979#discussion_r3106964885
##########
core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java:
##########
@@ -608,7 +682,9 @@ private static void liveEntry(PartitionStatistics stats,
ContentFile<?> file, Sn
updateSnapshotInfo(stats, snapshot.snapshotId(),
snapshot.timestampMillis());
}
- // Note: Not computing the `TOTAL_RECORD_COUNT` for now as it needs
scanning the data.
+ // Note: total_record_count is populated by populateTotalRecordCount()
after all
Review Comment:
the decision of whether total_record_count can be computed depends on final
aggregate state of a partition. Specifically on equalityDeleteRecordCount and
positionDeleteFileCount. these values are accumulated entry by entry in
liveEntry(). So the total can only be reliably determined after all entries are
processed and merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
