hemanthboyina commented on PR #15979: URL: https://github.com/apache/iceberg/pull/15979#issuecomment-4282457907
thanks @gaborkaszab , regarding the code complexity, with the internalSet null check fix which I mentioned, the implementation simplifies to a straightforward in-place loop (no object copying), which I think addresses the code complexity concern. I can push that simplified version if you'd like to take another look before escalating to dev@. Otherwise happy to raise the discussion there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
