RussellSpitzer commented on code in PR #15614:
URL: https://github.com/apache/iceberg/pull/15614#discussion_r3041539182
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -375,7 +383,21 @@ public boolean purgeTable(Identifier ident) {
String metadataFileLocation =
((HasTableOperations)
table).operations().current().metadataFileLocation();
- boolean dropped = dropTableWithoutPurging(ident);
+ if (isRestCatalog && !isPathIdentifier(ident)) {
+ if (restCatalogPurge) {
+ // Delegate purge to REST catalog - allows server-side features like
UNDROP
Review Comment:
I'm not sure you need this comment at all, we definitely don't want "server
-side features like UNDROP"
I would probably just drop the line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
