RussellSpitzer commented on code in PR #15614:
URL: https://github.com/apache/iceberg/pull/15614#discussion_r3041527040


##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalogProperties.java:
##########
@@ -55,6 +55,24 @@ private RESTCatalogProperties() {}
   public static final String TABLE_CACHE_MAX_ENTRIES = 
"rest-table-cache.max-entries";
   public static final int TABLE_CACHE_MAX_ENTRIES_DEFAULT = 100;
 
+  /**
+   * Controls whether engines using a REST Catalog should delegate DROP TABLE 
PURGE requests to the
+   * catalog server instead of performing client-side file deletion.
+   *
+   * <p>When enabled (true), the engine sends the purge request to the REST 
catalog, allowing the
+   * catalog to handle deletion. This enables features like UNDROP for REST 
catalogs that preserve
+   * deleted table metadata.
+   *
+   * <p>When disabled (false, default), the engine lists and deletes files 
client-side before
+   * dropping the table. This provides parallelized deletion but prevents 
server-side purge

Review Comment:
   The second sentence is again not needed here. Let's try to keep as much 
implementation detail out of the text as possible, especially since this only 
describes the Spark behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to