RussellSpitzer commented on code in PR #15614:
URL: https://github.com/apache/iceberg/pull/15614#discussion_r3041543816
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -375,7 +383,21 @@ public boolean purgeTable(Identifier ident) {
String metadataFileLocation =
((HasTableOperations)
table).operations().current().metadataFileLocation();
- boolean dropped = dropTableWithoutPurging(ident);
+ if (isRestCatalog && !isPathIdentifier(ident)) {
+ if (restCatalogPurge) {
+ // Delegate purge to REST catalog - allows server-side features like
UNDROP
+ return catalogDropTable(ident, true);
+ } else {
+ // Log warning: client-side purge bypasses server-side features
Review Comment:
remove the comment about UNDROP. The warning should say
Setting this to true will use the REST Catalog's capabilities to purge the
table.
Or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
