huaxingao commented on code in PR #15873:
URL: https://github.com/apache/iceberg/pull/15873#discussion_r3029307793
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalogProperties.java:
##########
@@ -42,10 +42,13 @@ private RESTCatalogProperties() {}
public static final String PAGE_SIZE = "rest-page-size";
public static final String NAMESPACE_SEPARATOR = "namespace-separator";
+ public static final String NAMESPACE_SEPARATOR_DEFAULT =
+ RESTUtil.NAMESPACE_SEPARATOR_URLENCODED_UTF_8;
// Configure scan planning mode
// Can be set by server in LoadTableResponse.config() for table-level
override
public static final String SCAN_PLANNING_MODE = "scan-planning-mode";
+ public static final String SCAN_PLANNING_MODE_DEFAULT =
ScanPlanningMode.CLIENT.name();
Review Comment:
I also feel enum is a better default type, but I notice that the
`SNAPSHOT_LOADING_MODE_DEFAULT` uses String `SnapshotMode.ALL.name()`. Maybe
worth updating that one too for consistency, either here or in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
