singhpk234 commented on code in PR #15873:
URL: https://github.com/apache/iceberg/pull/15873#discussion_r3027788019
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalogProperties.java:
##########
@@ -42,10 +42,13 @@ private RESTCatalogProperties() {}
public static final String PAGE_SIZE = "rest-page-size";
public static final String NAMESPACE_SEPARATOR = "namespace-separator";
+ public static final String NAMESPACE_SEPARATOR_DEFAULT =
+ RESTUtil.NAMESPACE_SEPARATOR_URLENCODED_UTF_8;
// Configure scan planning mode
// Can be set by server in LoadTableResponse.config() for table-level
override
public static final String SCAN_PLANNING_MODE = "scan-planning-mode";
+ public static final String SCAN_PLANNING_MODE_DEFAULT =
ScanPlanningMode.CLIENT.name();
Review Comment:
```suggestion
public static final ScanPlanningMode SCAN_PLANNING_MODE_DEFAULT =
ScanPlanningMode.CLIENT;
```
type of default doesn't necessarily have to be string
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -615,7 +615,8 @@ private RESTTable restTableForScanPlanning(
RESTCatalogProperties.ScanPlanningMode effectiveMode =
effectiveModeConfig != null
?
RESTCatalogProperties.ScanPlanningMode.fromString(effectiveModeConfig)
- : RESTCatalogProperties.ScanPlanningMode.CLIENT;
+ : RESTCatalogProperties.ScanPlanningMode.fromString(
+ RESTCatalogProperties.SCAN_PLANNING_MODE_DEFAULT);
Review Comment:
```suggestion
: RESTCatalogProperties.SCAN_PLANNING_MODE_DEFAULT;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
