nssalian commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r3024119904
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetFormatModel.java:
##########
@@ -42,39 +46,62 @@
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.parquet.column.ParquetProperties;
import org.apache.parquet.schema.MessageType;
+import org.apache.parquet.schema.Type;
public class ParquetFormatModel<D, S, R>
extends BaseFormatModel<D, S, ParquetValueWriter<?>, R, MessageType> {
public static final String WRITER_VERSION_KEY = "parquet.writer.version";
+ public static final String SHRED_VARIANTS_KEY =
TableProperties.PARQUET_VARIANT_SHRED;
+ public static final String VARIANT_BUFFER_SIZE_KEY =
TableProperties.PARQUET_VARIANT_BUFFER_SIZE;
+ public static final int DEFAULT_BUFFER_SIZE =
TableProperties.PARQUET_VARIANT_BUFFER_SIZE_DEFAULT;
private final boolean isBatchReader;
+ private final VariantShreddingAnalyzer<D, S> variantAnalyzer;
+ private final UnaryOperator<D> copyFunc;
Review Comment:
Removing it means anyone using BufferedFileAppender outside of
ParquetFormatModel must always provide a copy func even when their rows aren't
reused. Happy to remove if that's ok for a future use case. I left it in there
to be more flexible.
##########
core/src/main/java/org/apache/iceberg/io/BufferedFileAppender.java:
##########
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.io;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.function.Function;
+import java.util.function.UnaryOperator;
+import org.apache.iceberg.Metrics;
+import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+
+/**
+ * A FileAppender that buffers the first N rows, then creates a delegate
appender via a factory.
+ *
+ * <p>The factory receives the buffered rows and is responsible for creating
the real appender. Row
+ * replay is handled internally. All subsequent {@link #add} calls delegate
directly to the real
+ * appender.
+ *
+ * <p>If fewer than {@code bufferSize} rows are written before close, the
factory is called with
+ * whatever rows were buffered. If no rows were written, the factory is not
called and no file is
+ * created on disk. In this case, {@link #metrics()} returns {@code new
Metrics(0L)} and {@link
+ * #length()} returns {@code 0L}.
+ *
+ * @param <D> the row type
+ */
+public class BufferedFileAppender<D> implements FileAppender<D> {
+ private final int bufferRowCount;
+ private final Function<List<D>, FileAppender<D>> appenderFactory;
+ private final UnaryOperator<D> copyFunc;
+ private List<D> buffer;
+ private FileAppender<D> delegate;
+ private boolean closed = false;
+
+ /**
+ * @param bufferRowCount number of rows to buffer before creating the
delegate appender
+ * @param appenderFactory given the buffered rows, creates the delegate
appender
+ */
+ public BufferedFileAppender(
+ int bufferRowCount, Function<List<D>, FileAppender<D>> appenderFactory) {
+ this(bufferRowCount, appenderFactory, UnaryOperator.identity());
+ }
Review Comment:
Removing it means anyone using BufferedFileAppender outside of
ParquetFormatModel must always provide a copy func even when their rows aren't
reused. Happy to remove if that's ok for a future use case. I left it in there
to be more flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
