nssalian commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r3024119904
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetFormatModel.java:
##########
@@ -42,39 +46,62 @@
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.parquet.column.ParquetProperties;
import org.apache.parquet.schema.MessageType;
+import org.apache.parquet.schema.Type;
public class ParquetFormatModel<D, S, R>
extends BaseFormatModel<D, S, ParquetValueWriter<?>, R, MessageType> {
public static final String WRITER_VERSION_KEY = "parquet.writer.version";
+ public static final String SHRED_VARIANTS_KEY =
TableProperties.PARQUET_VARIANT_SHRED;
+ public static final String VARIANT_BUFFER_SIZE_KEY =
TableProperties.PARQUET_VARIANT_BUFFER_SIZE;
+ public static final int DEFAULT_BUFFER_SIZE =
TableProperties.PARQUET_VARIANT_BUFFER_SIZE_DEFAULT;
private final boolean isBatchReader;
+ private final VariantShreddingAnalyzer<D, S> variantAnalyzer;
+ private final UnaryOperator<D> copyFunc;
Review Comment:
Removing it means anyone using BufferedFileAppender outside of
ParquetFormatModel must always provide a copy func even when their rows aren't
reused. Happy to remove if that's ok for a future use case. I left it in there
to be more flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
