nssalian commented on PR #14297: URL: https://github.com/apache/iceberg/pull/14297#issuecomment-4152108974
Made some changes based on the previous feedback:
- Removed the file schema override and Spark-specific schema visitor. Now
all shredding goes through the FormatModel API.
- Moved column resolution into the analyzer so engine-specific logic stays
in engine subclasses.
- Redesigned the buffered appender with internal row replay
- Added table property precedence, round-trip tests, and docs.
Benchmarks should be added in a follow up PR, IMHO and any adjustments
should be made for inefficiencies.
@pvary @huaxingao @aihuaxu PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
