swapna267 commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3002492147
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java:
##########
@@ -52,27 +58,30 @@ class DynamicRecordProcessor<T> extends ProcessFunction<T,
DynamicRecordInternal
private transient TableUpdater updater;
private transient OutputTag<DynamicRecordInternal> updateStream;
private transient Collector<DynamicRecordInternal> collector;
+ private transient FlinkWriteConf flinkWriteConf;
private transient Context context;
DynamicRecordProcessor(
DynamicRecordGenerator<T> generator,
CatalogLoader catalogLoader,
- boolean immediateUpdate,
- int cacheMaximumSize,
- long cacheRefreshMs,
- int inputSchemasPerTableCacheMaximumSize,
TableCreator tableCreator,
- boolean caseSensitive,
- boolean dropUnusedColumns) {
+ Map<String, String> writeProperties,
+ Configuration flinkConfig) {
this.generator = generator;
this.catalogLoader = catalogLoader;
- this.immediateUpdate = immediateUpdate;
- this.cacheMaximumSize = cacheMaximumSize;
- this.cacheRefreshMs = cacheRefreshMs;
- this.inputSchemasPerTableCacheMaximumSize =
inputSchemasPerTableCacheMaximumSize;
+ this.writeProperties = writeProperties;
+ this.flinkConfig = flinkConfig;
+
+ FlinkDynamicSinkConf flinkDynamicSinkConf =
+ new FlinkDynamicSinkConf(writeProperties, flinkConfig);
Review Comment:
Did and removed for consistency.
DynamicRecordProcessor needs FlinkDynamicSinkConf and also
writeProperties/flinkConfig.
WriteProperties and FlinkConfig are required to create FlinkWriteConf in
Open as it's not serializable.
May be, I can simply pass FlinkDynamicSinkConf also along with
writeProperties/flinkConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
