danielcweeks commented on code in PR #15653:
URL: https://github.com/apache/iceberg/pull/15653#discussion_r2997397362
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -836,7 +838,10 @@ protected void validateAddedDVs(
List<ManifestFile> newDeleteManifests = history.first();
Set<Long> newSnapshotIds = history.second();
- Tasks.foreach(newDeleteManifests)
+ Iterable<ManifestFile> matchingManifests =
Review Comment:
I also validated this with spark and it does appear that even if the
partition spec is updated, any DV produced will be placed in a manifest with
the corresponding spec id for the associated file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
