anoopj commented on code in PR #15653:
URL: https://github.com/apache/iceberg/pull/15653#discussion_r2991502926
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -836,7 +838,10 @@ protected void validateAddedDVs(
List<ManifestFile> newDeleteManifests = history.first();
Set<Long> newSnapshotIds = history.second();
- Tasks.foreach(newDeleteManifests)
+ Iterable<ManifestFile> matchingManifests =
Review Comment:
I believe this scenario is forbidden by Iceberg spec and the reference
implementation: ie a DV and the data file must have the same partition spec. So
even if the default spec changes, the DV will take the data file's spec.
> "The data file's partition (both spec and partition values) is equal [4]
to the deletion vector's partition"
I added a guard to be defensive though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
