danielcweeks commented on code in PR #15653:
URL: https://github.com/apache/iceberg/pull/15653#discussion_r2990382041
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -836,7 +838,10 @@ protected void validateAddedDVs(
List<ManifestFile> newDeleteManifests = history.first();
Set<Long> newSnapshotIds = history.second();
- Tasks.foreach(newDeleteManifests)
+ Iterable<ManifestFile> matchingManifests =
Review Comment:
This is somewhat nuanced, but I believe we need an additional level of
validation that no snapshots between base and current have changed the
partition spec. If any snapshot was written with a different spec, it could
result in the partition filter improperly excluding a manifest and introducing
a duplicate DV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
