rdblue commented on code in PR #15561:
URL: https://github.com/apache/iceberg/pull/15561#discussion_r2921341880
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -319,9 +322,9 @@ private CloseableIterable<FileScanTask> scanTasksIterable(
/** Cancels the plan on the server (if supported) and closes the plan-scoped
FileIO */
private void cleanupPlanResources() {
cancelPlan();
- if (null != fileIOForPlanId) {
+ if (null != scanFileIO) {
FILEIO_TRACKER.invalidate(this);
- this.fileIOForPlanId = null;
+ this.scanFileIO = null;
Review Comment:
Why does this check whether `scanFileIO` is null? I think the tracker can
always be invalidated and `scanFileIO` can always be set to null. Since those
can be invariants of cleaning up, I think they should just run every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
