rdblue commented on code in PR #15561:
URL: https://github.com/apache/iceberg/pull/15561#discussion_r2921312213


##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -85,7 +85,7 @@ class RESTTableScan extends DataTableScan {
   private final Object hadoopConf;
   private final FileIO tableIO;
   private String planId = null;
-  private FileIO fileIOForPlanId = null;
+  private FileIO scanFileIO = null;

Review Comment:
   The table's `FileIO` is not needed. It is passed in only once as 
`table.io()` and `table` is also passed in. And now that I'm looking at it, 
`table` not needed as a field because a parent (`BaseScan`) exposes `table()`. 
Both fields should be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to