rdblue commented on code in PR #15561:
URL: https://github.com/apache/iceberg/pull/15561#discussion_r2927555844
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -212,14 +213,17 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
}
}
- private FileIO fileIOForPlanId(List<Credential> storageCredentials) {
+ private FileIO scanFileIO(List<Credential> storageCredentials) {
+ ImmutableMap.Builder<String, String> builder =
+ ImmutableMap.<String, String>builder().putAll(catalogProperties);
+ if (null != planId) {
+ builder.put(RESTCatalogProperties.REST_SCAN_PLAN_ID, planId);
Review Comment:
Fixing in a separate PR is fine, but we don't want to replace one blocker
with another endlessly as we find these issues.
We should also consider whether there are any alternatives to passing this
mixed into catalog properties. Passing state like this in a property map along
with config mixes concepts and causes weird API additions like this constant in
`RESTCatalogProperties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
