danielcweeks commented on code in PR #15209:
URL: https://github.com/apache/iceberg/pull/15209#discussion_r2796127075
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java:
##########
@@ -90,7 +86,8 @@ Table autoCreateTable(String tableName, SinkRecord sample) {
}
structType = type.asStructType();
} else {
- structType = SchemaUtils.toIcebergType(sample.valueSchema(),
config).asStructType();
+ structType =
+ SchemaUtils.toIcebergType(sample.valueSchema(), config,
formatVersion).asStructType();
Review Comment:
I would prefer that we don't push the format version down, but rather use a
flag to indicate that default values should be included (e.g. `includeDefaults`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
