brodiealexander commented on code in PR #2079:
URL: https://github.com/apache/iceberg-rust/pull/2079#discussion_r2742496971
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -1004,7 +1008,41 @@ mod tests {
HashMap::from([("exists".to_string(), "true".to_string())])
}
- async fn new_sql_catalog(warehouse_location: String) -> impl Catalog {
+ // async fn new_sql_catalog_with_name(
Review Comment:
Yes! Sorry, I had to re-do these changes like three times before I could
figure out how to include credit for @cornerwings work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
