liurenjie1024 commented on code in PR #2079:
URL: https://github.com/apache/iceberg-rust/pull/2079#discussion_r2739424489
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -1004,7 +1008,41 @@ mod tests {
HashMap::from([("exists".to_string(), "true".to_string())])
}
- async fn new_sql_catalog(warehouse_location: String) -> impl Catalog {
+ // async fn new_sql_catalog_with_name(
Review Comment:
Remove them if no longer used.
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -149,6 +147,12 @@ impl CatalogBuilder for SqlCatalogBuilder {
self.0.warehouse_location = warehouse_location;
}
+ let name = name.into();
+ let valid_name = !name.trim().is_empty();
+ if valid_name {
Review Comment:
Why not just return error here if no valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
