brodiealexander commented on code in PR #2079:
URL: https://github.com/apache/iceberg-rust/pull/2079#discussion_r2742490087
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -149,6 +147,12 @@ impl CatalogBuilder for SqlCatalogBuilder {
self.0.warehouse_location = warehouse_location;
}
+ let name = name.into();
+ let valid_name = !name.trim().is_empty();
+ if valid_name {
Review Comment:
It actually would return an error in the later lines in the async move {}
block, but I agree that it's unclear as it's presented here. I'll move it
around to make the flow a bit clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
