aiborodin commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2633639005
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -126,9 +125,14 @@ public void
commit(Collection<CommitRequest<DynamicCommittable>> commitRequests)
return;
}
- // For every table and every checkpoint, we store the list of
to-be-committed
- // DynamicCommittable.
- // There may be DynamicCommittable from previous checkpoints which have
not been committed yet.
+ /*
+ Each (table, branch, checkpoint) triplet must have only one commit
request.
+ There may be commit requests from previous checkpoints which have not
been committed yet.
+
+ We currently keep a List of commit requests per checkpoint instead of a
single CommitRequest<DynamicCommittable>
+ to process the Flink state from previous releases, which had multiple
commit requests due to a bug in the upstream
+ DynamicWriteResultAggregator. We should replace this with a single
commit request in the next major release.
Review Comment:
Releasing this change in the next patch release (eg 1.10.1) would allow us
to address the following points:
1. Fix Flink committable metrics: currently
`flink.taskmanager.job.task.operator.successfulCommittables` and similar report
incorrect values due to multiple committables coming into the committer, but
only the aggregated one getting committed.
2. Avoid writing extra manifests: sink would only write one temporary
manifest per table, branch, partition spec, while currently, it writes a new
temporary manifest for each unique WriteTarget (table, branch, schemaId,
specId, upsertMode, equalityFields).
It would also allow us to simplify the code a lot, as we could remove lists
in the next minor release (1.11).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
