pvary commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2622378706
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -210,36 +213,32 @@ private void commitPendingRequests(
NavigableMap<Long, List<WriteResult>> pendingResults = Maps.newTreeMap();
for (Map.Entry<Long, List<CommitRequest<DynamicCommittable>>> e :
commitRequestMap.entrySet()) {
for (CommitRequest<DynamicCommittable> committable : e.getValue()) {
- if (Arrays.equals(EMPTY_MANIFEST_DATA,
committable.getCommittable().manifest())) {
Review Comment:
If we remove `EMPTY_MANIFEST_DATA` handling (as it is not really used), then
we should remove
```
static final String MAX_CONTINUOUS_EMPTY_COMMITS =
"flink.max-continuous-empty-commits";
[..]
private final Map<TableKey, Integer> maxContinuousEmptyCommitsMap;
private final Map<TableKey, Integer> continuousEmptyCheckpointsMap;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
