pvary commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2619051403
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -57,11 +58,11 @@ class DynamicWriteResultAggregator
implements OneInputStreamOperator<
CommittableMessage<DynamicWriteResult>,
CommittableMessage<DynamicCommittable>> {
private static final Logger LOG =
LoggerFactory.getLogger(DynamicWriteResultAggregator.class);
- private static final byte[] EMPTY_MANIFEST_DATA = new byte[0];
+ private static final byte[][] EMPTY_MANIFEST_DATA = new byte[0][];
Review Comment:
QQ: When can we have empty manifest data? Do we need it with the Dynamic
Sink?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
