joyhaldar commented on code in PR #14447:
URL: https://github.com/apache/iceberg/pull/14447#discussion_r2631038895
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java:
##########
@@ -81,23 +73,17 @@ public BigQueryMetastoreCatalog() {}
@Override
public void initialize(String name, Map<String, String> properties) {
- Preconditions.checkArgument(
- properties.containsKey(PROJECT_ID),
- "Invalid GCP project: %s must be specified",
- PROJECT_ID);
- this.projectId = properties.get(PROJECT_ID);
- this.projectLocation = properties.getOrDefault(GCP_LOCATION,
DEFAULT_GCP_LOCATION);
+ this.projectId = properties.get(BigQueryProperties.PROJECT_ID);
Review Comment:
I have refactored to create BigQueryProperties first and use parsed values
from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
