joyhaldar commented on code in PR #14447:
URL: https://github.com/apache/iceberg/pull/14447#discussion_r2633570304
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java:
##########
@@ -58,14 +57,25 @@
public class BigQueryMetastoreCatalog extends BaseMetastoreCatalog
implements SupportsNamespaces, Configurable<Object> {
- // User provided properties.
- public static final String PROJECT_ID = "gcp.bigquery.project-id";
- public static final String GCP_LOCATION = "gcp.bigquery.location";
- public static final String LIST_ALL_TABLES = "gcp.bigquery.list-all-tables";
+ /**
+ * @deprecated since 1.11.0, will be removed in 1.12.0; use {@link
BigQueryProperties#PROJECT_ID}
+ * instead.
+ */
+ @Deprecated public static final String PROJECT_ID =
"gcp.bigquery.project-id";
Review Comment:
I tried putting it on a separate line, but Spotless reformatted it back.
Looking at the codebase, there are mixed styles, for example,
[TableProperties.java](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableProperties.java)
uses same line format
[here](https://github.com/apache/iceberg/blob/05998edb8808ae21739072cca17b621925a2081a/core/src/main/java/org/apache/iceberg/TableProperties.java#L287).
Let me know if you'd like me to override Spotless for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
