joyhaldar commented on code in PR #14447: URL: https://github.com/apache/iceberg/pull/14447#discussion_r2594654677
########## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientFactory.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.gcp.bigquery; + +import com.google.cloud.bigquery.BigQueryOptions; +import java.io.Serializable; +import java.util.Map; + +/** + * Factory for creating configured BigQueryOptions (pluggable auth). Implementations create + * BigQueryOptions from catalog properties. + */ +public interface BigQueryClientFactory extends Serializable { Review Comment: Thank you @danielcweeks, I think I understand now, separating config by component (BigQuery vs GCS) rather than by auth method (impersonation vs default). I looked at how AWS does this, `AssumeRoleAwsClientFactory` uses [applyAssumeRoleConfigurations()](https://github.com/apache/iceberg/blob/1c024d7c4e66a0654118d30d04a0d9c0c5ab4de3/aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java#L120) to apply the same credentials to all clients (S3, Glue, DynamoDB). They all read [client.assume-role.arn](https://github.com/apache/iceberg/blob/1c024d7c4e66a0654118d30d04a0d9c0c5ab4de3/aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java#L123) from `AwsProperties`, there's no separate assume-role config for S3 vs Glue from what I understand, please correct me if I am incorrect. The issue I'm running into is that `iceberg-bigquery` and `iceberg-gcp` are currently separate modules with no dependency between them. So [BigQueryMetastoreCatalog](https://github.com/apache/iceberg/blob/main/bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java) can't directly use [GCPProperties](https://github.com/apache/iceberg/blob/main/gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java) from the gcp module. This is what I was thinking: 1. Create `BigQueryProperties` in bigquery module with `metastoreOptions()`. 2. Add `storageOptions()` to `GCPProperties` in gcp module. 3. Both classes define `gcp.impersonate.service-account` and read from the same properties map. If I'm following the AWS pattern correctly, the shared config would be the property key rather than a shared Java class. So when users set `gcp.impersonate.service-account`, both `BigQuery` and `GCS` can use it. Does this approach make sense, or would you suggest a different direction? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
