nastra commented on code in PR #14392:
URL: https://github.com/apache/iceberg/pull/14392#discussion_r2613974131
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthManagers.java:
##########
@@ -31,15 +31,20 @@ public class AuthManagers {
private static final Logger LOG =
LoggerFactory.getLogger(AuthManagers.class);
- /** Old property name for enabling SigV4 authentication. */
- private static final String SIGV4_ENABLED_LEGACY = "rest.sigv4-enabled";
+ /**
+ * Old property name for enabling SigV4 authentication.
+ *
+ * @deprecated Use {@link AuthProperties#AUTH_TYPE}={@link
AuthProperties#AUTH_TYPE_SIGV4}
+ * instead. Will be removed in 1.12.0.
+ */
+ @Deprecated private static final String SIGV4_ENABLED_LEGACY =
"rest.sigv4-enabled";
Review Comment:
this is actually a fallback mechanism so that older clients still work. When
this property is removed, we want to make sure to switch the warn to an error
msg but still leave the fallback mechanism in-place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
