gaborkaszab commented on code in PR #14392:
URL: https://github.com/apache/iceberg/pull/14392#discussion_r2606853783
##########
core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java:
##########
@@ -129,7 +129,7 @@ public static Schema pruneColumns(Schema schema,
Set<Integer> selectedIds) {
}
/**
- * @deprecated will be removed in 2.0.0; use applyNameMapping and
pruneColumns(Schema, Set)
+ * @deprecated will be removed in 1.12.0; use applyNameMapping and
pruneColumns(Schema, Set)
Review Comment:
There was a discussion about this in one of the community syncs. The
conclusion was that we give guarantees for a whole major version in the api/
module, however in the core/ module we could be less strict and provide
guarantees for one minor release. Technically deprecate in the upcoming minor,
drop in the one after that is OK in core. Hence, this PR collects all the
deprecations in core/ marking removal for 2.0.0 to revisit them and drop
earlier if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
