gaborkaszab commented on code in PR #14392:
URL: https://github.com/apache/iceberg/pull/14392#discussion_r2602716525
##########
core/src/main/java/org/apache/iceberg/io/ContentCache.java:
##########
@@ -140,7 +140,7 @@ public void invalidate(String key) {
}
/**
- * @deprecated since 1.7.0, will be removed in 2.0.0; This method does only
best-effort
+ * @deprecated since 1.7.0, will be removed in 1.12.0; This method does only
best-effort
Review Comment:
What is an alternative way to empty the cache?
##########
core/src/main/java/org/apache/iceberg/view/ViewProperties.java:
##########
@@ -27,7 +27,7 @@ public class ViewProperties {
public static final String METADATA_COMPRESSION_DEFAULT = "gzip";
/**
- * @deprecated will be removed in 2.0.0, use {@link
ViewBuilder#withLocation} instead.
+ * @deprecated will be removed in 1.12.0, use {@link
ViewBuilder#withLocation} instead.
Review Comment:
set back to 2.0.0
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcTableConcurrency.java:
##########
@@ -646,7 +646,8 @@ public void setAsciiStream(int parameterIndex, InputStream
x, int length) throws
delegate.setAsciiStream(parameterIndex, x, length);
}
- @Deprecated(since = "1.2")
+ /* @deprecated Will be removed in 1.12.0 */
Review Comment:
check if tests pass without this
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -84,7 +84,7 @@ public static MetricsConfig forPositionDelete() {
* Creates a metrics config from table configuration.
*
* @param props table configuration
- * @deprecated use {@link MetricsConfig#forTable(Table)}
+ * @deprecated use {@link MetricsConfig#forTable(Table)}. Will be removed in
1.12.0
Review Comment:
Change back to 2.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
