HuaHuaY commented on code in PR #321:
URL: https://github.com/apache/iceberg-cpp/pull/321#discussion_r2603510183
##########
src/iceberg/table.cc:
##########
@@ -114,7 +115,7 @@ std::unique_ptr<UpdateProperties> Table::UpdateProperties()
const {
}
std::unique_ptr<Transaction> Table::NewTransaction() const {
- throw NotImplemented("Table::NewTransaction is not implemented");
+ return std::make_unique<BaseTransaction>(shared_from_this(), catalog_);
Review Comment:
When the table‘s content changes, or we drop a table, what should the
executing transaction hold?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
