HuaHuaY commented on code in PR #321:
URL: https://github.com/apache/iceberg-cpp/pull/321#discussion_r2596332621
##########
src/iceberg/catalog/memory/in_memory_catalog.h:
##########
@@ -77,8 +79,8 @@ class ICEBERG_EXPORT InMemoryCatalog
Result<std::unique_ptr<Table>> UpdateTable(
const TableIdentifier& identifier,
- const std::vector<std::unique_ptr<TableRequirement>>& requirements,
- const std::vector<std::unique_ptr<TableUpdate>>& updates) override;
+ std::vector<std::unique_ptr<TableRequirement>> requirements,
Review Comment:
Use forward declarations instead of including header file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
