lishuxu commented on code in PR #321: URL: https://github.com/apache/iceberg-cpp/pull/321#discussion_r2616171484
########## src/iceberg/base_transaction.h: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <memory> +#include <vector> + +#include "iceberg/table_identifier.h" +#include "iceberg/table_requirement.h" +#include "iceberg/table_update.h" +#include "iceberg/transaction.h" +#include "iceberg/type_fwd.h" + +namespace iceberg { + +/// \brief Base class for transaction implementations +class ICEBERG_EXPORT BaseTransaction : public Transaction { + public: + BaseTransaction(std::shared_ptr<const Table> table, std::shared_ptr<Catalog> catalog); + ~BaseTransaction() override = default; + + const std::shared_ptr<const Table>& table() const override; + + std::unique_ptr<::iceberg::UpdateProperties> UpdateProperties() override; + + std::unique_ptr<AppendFiles> NewAppend() override; Review Comment: Thanks for the suggestion. In the current transaction implementation, we don’t need to collect or retain PendingUpdate instances across the transaction lifecycle, so returning std::unique_ptr keeps the ownership semantics explicit and avoids introducing shared ownership where it isn’t required. I agree that returning shared_ptr could make internal aggregation or transformation of updates easier if the transaction logic evolves in that direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
