gaborkaszab commented on code in PR #14808:
URL: https://github.com/apache/iceberg/pull/14808#discussion_r2603359352
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -118,7 +118,8 @@
public class TestRESTCatalog extends CatalogTests<RESTCatalog> {
private static final ObjectMapper MAPPER = RESTObjectMapper.mapper();
private static final ResourcePaths RESOURCE_PATHS =
- ResourcePaths.forCatalogProperties(Maps.newHashMap());
+ ResourcePaths.forCatalogProperties(
Review Comment:
In the meantime I just checked the usage of
`TestRESTCatalog.RESOURCE_PATHS`. Apparently, it is not used for configuring
the client, nor the server, its usage is mostly in `Mockito.verify()` to see if
proper endpoints were called. There are 3-4 occasions in `Mockito.doThrow()`
and `Mockito.doAnswer()` where this is used, but not with multi-level
namespaces. The exception is the above mentioned `TestNotModified` only.
So, if I don't miss anything, it's safe and we won't loose any coverage to
make the adjustment within this PR as we don't change client behavior with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
