gaborkaszab commented on code in PR #14808:
URL: https://github.com/apache/iceberg/pull/14808#discussion_r2603285152
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -118,7 +118,8 @@
public class TestRESTCatalog extends CatalogTests<RESTCatalog> {
private static final ObjectMapper MAPPER = RESTObjectMapper.mapper();
private static final ResourcePaths RESOURCE_PATHS =
- ResourcePaths.forCatalogProperties(Maps.newHashMap());
+ ResourcePaths.forCatalogProperties(
Review Comment:
I see. Not sure if there was a specific ask for this, but wouldn't it make
sense to do this the other way around: Change the test suite to act as the
"newer" clients, and have some coverage in separate tests to cover some
use-case with the "older" client? I'd find two reasons for this: 1) otherwise
new tests have to do the hacky way of creating their own ResourcePath with the
new separator (this is something has to be cleaned up later, but can be easy to
forget), and 2) "for a while" could easily turn into "forever" :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
