nastra commented on code in PR #14808:
URL: https://github.com/apache/iceberg/pull/14808#discussion_r2603328602
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -118,7 +118,8 @@
public class TestRESTCatalog extends CatalogTests<RESTCatalog> {
private static final ObjectMapper MAPPER = RESTObjectMapper.mapper();
private static final ResourcePaths RESOURCE_PATHS =
- ResourcePaths.forCatalogProperties(Maps.newHashMap());
+ ResourcePaths.forCatalogProperties(
Review Comment:
Switching everything to behave like a "new" client could hide potential
issues. That's why I left everything as-is for a while, but I agree that
changing this can be easily forgotten. Would you mind opening an issue to
address this (e.g. after the next release or so). You can leave your PR open
until then.
Also there's currently really only one test that has to do an adjustment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
