HuaHuaY commented on code in PR #386:
URL: https://github.com/apache/iceberg-cpp/pull/386#discussion_r2597562926
##########
src/iceberg/catalog/memory/in_memory_catalog.cc:
##########
@@ -394,7 +411,32 @@ Result<std::unique_ptr<Table>>
InMemoryCatalog::UpdateTable(
const TableIdentifier& identifier,
const std::vector<std::unique_ptr<TableRequirement>>& requirements,
const std::vector<std::unique_ptr<TableUpdate>>& updates) {
- return NotImplemented("update table");
+ std::unique_lock lock(mutex_);
Review Comment:
I agree that we may be able to replace the lock type with
`std::shared_lock`. If you don't do that in this PR, I hope that you can
replace with `std::lock_guard` first. Because we have merged a PR
https://github.com/apache/iceberg-cpp/pull/398 which replaced the other
`unique_lock` in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
