WZhuo commented on code in PR #386:
URL: https://github.com/apache/iceberg-cpp/pull/386#discussion_r2597403301
##########
src/iceberg/catalog/memory/in_memory_catalog.cc:
##########
@@ -394,7 +411,32 @@ Result<std::unique_ptr<Table>>
InMemoryCatalog::UpdateTable(
const TableIdentifier& identifier,
const std::vector<std::unique_ptr<TableRequirement>>& requirements,
const std::vector<std::unique_ptr<TableUpdate>>& updates) {
- return NotImplemented("update table");
+ std::unique_lock lock(mutex_);
Review Comment:
I think it can be optimized with ReadWriteLock later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
