WZhuo commented on code in PR #386: URL: https://github.com/apache/iceberg-cpp/pull/386#discussion_r2597382191
########## src/iceberg/table_metadata.cc: ########## @@ -258,13 +290,95 @@ Result<std::unique_ptr<TableMetadata>> TableMetadataUtil::Read( return TableMetadataFromJson(json); } +Status TableMetadataUtil::Write(FileIO& io, const TableMetadata* base, Review Comment: The base can be nullptr, indicating that this is creating a new table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
