HuaHuaY commented on code in PR #373:
URL: https://github.com/apache/iceberg-cpp/pull/373#discussion_r2593510118
##########
src/iceberg/expression/aggregate.h:
##########
@@ -143,11 +147,16 @@ class ICEBERG_EXPORT BoundAggregate : public
Aggregate<BoundTerm>, public Bound
class ICEBERG_EXPORT CountAggregate : public BoundAggregate {
public:
Result<Literal> Evaluate(const StructLike& data) const final;
+ Result<Literal> Evaluate(const DataFile& file) const override;
Review Comment:
```suggestion
Result<Literal> Evaluate(const DataFile& file) const final;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
