wgtmac commented on code in PR #373:
URL: https://github.com/apache/iceberg-cpp/pull/373#discussion_r2583420963
##########
src/iceberg/expression/aggregate.cc:
##########
@@ -38,6 +40,58 @@ std::shared_ptr<PrimitiveType> GetPrimitiveType(const
BoundTerm& term) {
return internal::checked_pointer_cast<PrimitiveType>(term.type());
}
+Result<Scalar> LiteralToScalar(const Literal& literal) {
+ if (literal.IsNull()) {
+ return Scalar{std::monostate{}};
+ }
+
+ switch (literal.type()->type_id()) {
+ case TypeId::kBoolean:
+ return Scalar{std::get<bool>(literal.value())};
+ case TypeId::kInt:
+ case TypeId::kDate:
+ return Scalar{std::get<int32_t>(literal.value())};
+ case TypeId::kLong:
+ case TypeId::kTime:
+ case TypeId::kTimestamp:
+ case TypeId::kTimestampTz:
+ return Scalar{std::get<int64_t>(literal.value())};
+ case TypeId::kFloat:
+ return Scalar{std::get<float>(literal.value())};
+ case TypeId::kDouble:
+ return Scalar{std::get<double>(literal.value())};
+ case TypeId::kString: {
+ const auto& str = std::get<std::string>(literal.value());
+ return Scalar{std::string_view(str)};
+ }
+ case TypeId::kBinary:
+ case TypeId::kFixed: {
+ const auto& bytes = std::get<std::vector<uint8_t>>(literal.value());
+ return Scalar{
+ std::string_view(reinterpret_cast<const char*>(bytes.data()),
bytes.size())};
+ }
+ case TypeId::kDecimal:
+ return Scalar{std::get<Decimal>(literal.value())};
+ default:
+ return NotSupported("Cannot convert literal of type {} to Scalar",
+ literal.type()->ToString());
+ }
+}
+
+class SingleValueStructLike : public StructLike {
+ public:
+ explicit SingleValueStructLike(Literal literal) :
literal_(std::move(literal)) {}
+
+ Result<Scalar> GetField(size_t /*pos*/) const override {
Review Comment:
SGTM. Thanks for the explaination!
##########
src/iceberg/expression/aggregate.cc:
##########
@@ -38,6 +40,58 @@ std::shared_ptr<PrimitiveType> GetPrimitiveType(const
BoundTerm& term) {
return internal::checked_pointer_cast<PrimitiveType>(term.type());
}
+Result<Scalar> LiteralToScalar(const Literal& literal) {
+ if (literal.IsNull()) {
+ return Scalar{std::monostate{}};
+ }
+
+ switch (literal.type()->type_id()) {
+ case TypeId::kBoolean:
+ return Scalar{std::get<bool>(literal.value())};
+ case TypeId::kInt:
+ case TypeId::kDate:
+ return Scalar{std::get<int32_t>(literal.value())};
+ case TypeId::kLong:
+ case TypeId::kTime:
+ case TypeId::kTimestamp:
+ case TypeId::kTimestampTz:
+ return Scalar{std::get<int64_t>(literal.value())};
+ case TypeId::kFloat:
+ return Scalar{std::get<float>(literal.value())};
+ case TypeId::kDouble:
+ return Scalar{std::get<double>(literal.value())};
+ case TypeId::kString: {
+ const auto& str = std::get<std::string>(literal.value());
+ return Scalar{std::string_view(str)};
+ }
+ case TypeId::kBinary:
+ case TypeId::kFixed: {
+ const auto& bytes = std::get<std::vector<uint8_t>>(literal.value());
+ return Scalar{
+ std::string_view(reinterpret_cast<const char*>(bytes.data()),
bytes.size())};
+ }
+ case TypeId::kDecimal:
+ return Scalar{std::get<Decimal>(literal.value())};
+ default:
+ return NotSupported("Cannot convert literal of type {} to Scalar",
+ literal.type()->ToString());
+ }
+}
+
+class SingleValueStructLike : public StructLike {
+ public:
+ explicit SingleValueStructLike(Literal literal) :
literal_(std::move(literal)) {}
+
+ Result<Scalar> GetField(size_t /*pos*/) const override {
Review Comment:
SGTM. Thanks for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
