HuaHuaY commented on code in PR #373:
URL: https://github.com/apache/iceberg-cpp/pull/373#discussion_r2593496696
##########
src/iceberg/expression/aggregate.cc:
##########
@@ -315,6 +533,15 @@ class AggregateEvaluatorImpl : public AggregateEvaluator {
return all.front();
}
+ bool AllAggregatorsValid() const override {
+ for (const auto& aggregator : aggregators_) {
+ if (!aggregator->IsValid()) {
+ return false;
+ }
+ }
+ return true;
Review Comment:
```suggestion
return std::ranges::all_of(aggregators_,
&BoundAggregate::Aggregator::IsValid);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
