smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2553677534
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -241,12 +328,38 @@ private static Long
expectedSnapshotIdIfSnapshotAddOnly(List<MetadataUpdate> upd
return addedSnapshotId;
}
+ private void encryptionPropsFromMetadata(TableMetadata metadata) {
+ if (metadata == null || metadata.properties() == null) {
+ return;
+ }
+
+ encryptedKeysFromMetadata = metadata.encryptionKeys();
+
+ Map<String, String> tableProperties = metadata.properties();
+ if (tableKeyId == null) {
Review Comment:
I think the question more generally is whether encryption-related properties
should be refreshed. On second thought and looking at the Hive implementation,
I've made the change to do so. (This method is used differently to the similar
one for Hive)
The question of encryption property changes on the "temporary" table
operations of an encrypted table (used e.g. during a transaction, or when you
replace a table "as select") feels more delicate, and I believe the current
stance is not to respect those changes (the Hive implementation doesn't). So,
the `temp` operations on this class similarly do not use the uncommitted
metadata's properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
